RFR: 8327261: Parsing test for Double/Float succeeds w/o testing all bad cases
Joe Darcy
darcy at openjdk.org
Tue Mar 5 02:29:53 UTC 2024
On Tue, 5 Mar 2024 00:51:33 GMT, Naoto Sato <naoto at openjdk.org> wrote:
> Fixing test cases. For bad test cases, only the first case was run, and the rest were ignored.
Looks fine; thanks for sending out the fix.
test/jdk/java/lang/Double/ParseDouble.java line 559:
> 557: private static void testParsing(String [] input,
> 558: boolean exceptionalInput) {
> 559: for(int i = 0; i < input.length; i++) {
As you're updating the file, I think changing the loop to an enhanced for loop would be an improvement.
-------------
Marked as reviewed by darcy (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18113#pullrequestreview-1915727056
PR Review Comment: https://git.openjdk.org/jdk/pull/18113#discussion_r1512050441
More information about the core-libs-dev
mailing list