RFR: 8327225: Revert DataInputStream.readUTF to static final

Guoxiong Li gli at openjdk.org
Tue Mar 5 12:27:45 UTC 2024


On Mon, 4 Mar 2024 13:55:15 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> [JDK-8325340](https://bugs.openjdk.org/browse/JDK-8325340) accidentally removed `final` from the `static final DataInputStream.readUTF` method. This has a minor compatibility impact (allows hiding the method in a subclass, while before that would throw an exception at compile time) and since it was not the intent of the prior change to alter any behavioral semantics here I want to revert that change.

> It's a bit unusual to have the final modifier on static methods

I searched the `public static final` and `public final static` in the code base. Currently, some methods, if not many, also use the `public final static`.

I would be OK with this patch.

-------------

Marked as reviewed by gli (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18107#pullrequestreview-1916756792


More information about the core-libs-dev mailing list