RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v4]

Jim Laskey jlaskey at openjdk.org
Tue Mar 5 20:23:56 UTC 2024


> Currently, add is returning intern(e) == null which will always be false. The correct test is intern(e) == e , that is, true when element is newly added.

Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:

  Fix ReferencedKeySet::add

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17732/files
  - new: https://git.openjdk.org/jdk/pull/17732/files/51cf3e4a..72859919

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17732&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17732&range=02-03

  Stats: 30 lines in 3 files changed: 26 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/17732.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17732/head:pull/17732

PR: https://git.openjdk.org/jdk/pull/17732


More information about the core-libs-dev mailing list