RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v4]

Roger Riggs rriggs at openjdk.org
Tue Mar 5 21:42:46 UTC 2024


On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Currently, add is returning intern(e) == null which will always be false. The correct test is intern(e) == e , that is, true when element is newly added.
>
> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix ReferencedKeySet::add

LGTM

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17732#pullrequestreview-1918184517


More information about the core-libs-dev mailing list