RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v18]

[Severin Gehwolf]

On Wed, 6 Mar 2024 17:28:01 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Only show runtime image suffix for JDK modules
>
> make/ToolsJdk.gmk line 88:
> 
>> 86:     --add-modules=jdk.jlink --add-exports=java.base/jdk.internal.module=ALL-UNNAMED \
>> 87:     --add-exports=java.base/jdk.internal.jimage=ALL-UNNAMED \
>> 88:     build.tools.runtimelink.JimageDiffGenerator
> 
> While it might be a bit redundant, we try to keep the same name in the make name, the package and the main class, e.g. something like:
> 
> Suggestion:
> 
> TOOL_JIMAGE_DIFF_GENERATOR = $(BUILD_JAVA_SMALL) -cp $(BUILDTOOLS_OUTPUTDIR)/jdk_tools_classes \
>     --add-modules=jdk.jlink --add-exports=java.base/jdk.internal.module=ALL-UNNAMED \
>     --add-exports=java.base/jdk.internal.jimage=ALL-UNNAMED \
>     build.tools.jimagediffgenerator.JimageDiffGenerator
> 
> 
> This is of course not consistently followed, but for new tooling I think it would be a good idea to try and follow.

Based on some private feedback I've got it seems this will change a bit (move to the `jdk.jlink` module instead). But if still relevant, I'll keep that in mind. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1515040874