RFR: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out [v2]

[Jaikiran Pai]

On Thu, 7 Mar 2024 10:20:55 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> As an intermediate fix to the test, switching to explicit usage of an ExecutorService seems to do the trick to make this test reliably pass.
>> 
>> With that said, this test (CHM::ToArray.java) seems to trigger an issue in ForkJoinPool, so that would need to be fixed separately.
>> 
>> Tagging @DougLea as an FYI. :)
>
> Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updating copyright year of CHM/ToArray.java

The intention of this `ToArray` as noted in the summary of this test is to verify the thread safety of the `toArray()` methods of collection views. As noted in the JBS issue, the reason why this test keeps timing out intermittently appears to be an issue in the `ForkJoinPool` and thus those timeouts aren't exposing any issues within `toArray()` implementations itself. So it seems fine that we are switching over to using a thread pool that doesn't exhibit those issues.

This proposed change looks good to me. Since Doug has already approved this too, I will go ahead and officially mark this as reviewed.

Before integrating, please update the copyright year on this file.

Marked as reviewed by jpai (Reviewer).

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18023#pullrequestreview-1922028143
PR Review: https://git.openjdk.org/jdk/pull/18023#pullrequestreview-1922040153