RFR: 8325567: jspawnhelper without args fails with segfault

[Vladimir Petko]

On Tue, 5 Mar 2024 17:56:21 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> This change is intended to address the segmentation fault issue that occurs when jspawnhelper is called without arguments,.
>> There is a new test added  to verify the behavior in such cases.
>> 
>> `[ec2-user at ip-172-16-0-10 jdk]$ make CONF=linux-x86_64-server-fastdebug test TEST=test/jdk/java/lang/ProcessBuilder/JspawnhelperWarnings.java`
>> 
>> 
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR
>>    jtreg:test/jdk/java/lang/ProcessBuilder/JspawnhelperWarnings.java
>>                                                          1     1     0     0
>> ==============================
>> TEST SUCCESS
>
> I'm curious why this test is requires `vm.debug`?  That means it generally won't get run on release builds.

> Let's see if @RogerRiggs and @vpa1977 have any additional feedback.

Hi, the changes look good, just a minor note regarding waitFor() removal. OutputAnalyzer/LazyOutputBuffer do not have timeout on waitFor() so in a rare case when jspawnhelper is stuck, the test might block the CI.
It is hardly possible with the current implementation, but might become a possibility in the future.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18112#issuecomment-1984253692