RFR: 8327791: Optimization for new BigDecimal(String) [v4]
Shaojin Wen
duke at openjdk.org
Mon Mar 11 20:41:25 UTC 2024
> The current BigDecimal(String) constructor calls String#toCharArray, which has a memory allocation.
>
>
> public BigDecimal(String val) {
> this(val.toCharArray(), 0, val.length()); // allocate char[]
> }
>
>
> When the length is greater than 18, create a char[]
>
>
> boolean isCompact = (len <= MAX_COMPACT_DIGITS); // 18
> if (!isCompact) {
> // ...
> } else {
> char[] coeff = new char[len]; // allocate char[]
> // ...
> }
>
>
> This PR eliminates the two memory allocations mentioned above, resulting in an approximate 60% increase in performance..
Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
1. bug fix for CharBuffer catch IndexOutOfBoundsException
2. reorder if statement
3. Improve the performance of !isCompact branch
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18177/files
- new: https://git.openjdk.org/jdk/pull/18177/files/bdf9f4b5..bb45da4d
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18177&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18177&range=02-03
Stats: 70 lines in 1 file changed: 41 ins; 17 del; 12 mod
Patch: https://git.openjdk.org/jdk/pull/18177.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18177/head:pull/18177
PR: https://git.openjdk.org/jdk/pull/18177
More information about the core-libs-dev
mailing list