RFR: 8327460: Compile tests with the same visibility rules as product code [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Tue Mar 12 13:59:16 UTC 2024
On Mon, 11 Mar 2024 02:31:02 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update line number for dereference_null in TestDwarf
>
> test/hotspot/jtreg/runtime/ErrorHandling/libTestDwarfHelper.h line 24:
>
>> 22: */
>> 23:
>> 24: #include <stdio.h>
>
> Seems unneeded.
So what I did here was change:
#include "jni.h"
#include <stdio.h>
into
#include <stdio.h>
#include "export.h"
#include "jni.h"
The reordering was strictly not needed, but putting user includes in front of system ones looked like bad coding to me, and put me in a difficult spot in where to add the new `#include "export.h"` -- next to the current user include even if I thought that was wrong, or have the system includes "sandwitched" between two user includes.
Or do you mean that it seems unneeded to include `jni.h` at all? Yes, I agree, but it was there before, and I don't want to make any other changes to the tests. This change is scary enough as it is :-). If you want, I can file a follow-up to remove this include instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18135#discussion_r1521510510
More information about the core-libs-dev
mailing list