RFR: 8325621: Improve jspawnhelper version checks [v2]

[Magnus Ihse Bursie]

On Mon, 11 Mar 2024 20:04:48 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Code cleanup
>
> make/modules/java.base/Launcher.gmk line 85:
> 
>> 83:           -DVERSION_INTERIM=$(VERSION_INTERIM) \
>> 84:           -DVERSION_UPDATE=$(VERSION_UPDATE) \
>> 85:           -DVERSION_PATCH=$(VERSION_PATCH), \
> 
> Using all 4 is way overkill for the problem at hand.  Just the FEATURE_VERSION is sufficient.
> We all know better than to make incompatible changes in minor versions let alone update or patch version.

There is already a `$(VERSION_CFLAGS)` variable defined. It will set all those (and some more). Please use it instead. But then, as Roger says, it is probably overkill to *check* anything but the feature version.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18204#discussion_r1521525658