RFR: 8325621: Improve jspawnhelper version checks [v2]

[Erik Joelsson]

On Mon, 11 Mar 2024 19:12:33 GMT, Chad Rakoczy <duke at openjdk.org> wrote:

>> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>> 
>> Updates jspawnhelper to check that JDK version and jspawnhelper version are the same. Updates test to include check for version. Also tested manually by replacing jspawnhelper with incorrect version to confirm that check works.
>
> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Code cleanup

I'm fine with just using VERSION_FEATURE. I think it's a simple and straightforward enough simplification/approximation. If we think we need a more exact version comparison, then I think we should use one of the version strings instead of arbitrarily picking a set of version variables.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18204#issuecomment-1992318595