RFR: 8328074: Add jcheck whitespace checking for assembly files [v3]

Magnus Ihse Bursie ihse at openjdk.org
Wed Mar 13 11:59:37 UTC 2024


On Wed, 13 Mar 2024 11:45:33 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As part of the ongoing effort to enable jcheck whitespace checking to all text files, it is now time to address assembly (.S) files. The hotspot assembly files were fixed as part of the hotspot mapfile removal, so only a single incorrect jdk library remains.
>> 
>> The main issue with `libjsvml` was inconsistent line starts, sometimes using tabs. I used the `expand` unix command line tool to replace these with spaces.
>
> Magnus Ihse Bursie has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains two commits:
> 
>  - Enable jcheck whitespace checks for .S files
>  - Run expand on libjsvml

I tagged this `core-libs` as that is what @sviswa7 did for changes to libjsvml in https://github.com/openjdk/jdk/pull/8508. I hope this is correct. (We should really add rules to Skara for this library.)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18268#issuecomment-1994211386


More information about the core-libs-dev mailing list