RFR: 8328037: Test java/util/Formatter/Padding.java has unnecessary high heap requirement after JDK-8326718 [v3]

Raffaello Giulietti rgiulietti at openjdk.org
Thu Mar 14 10:33:44 UTC 2024


On Wed, 13 Mar 2024 21:07:54 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> 4f336085d1098e7fba7b58f0a73c028179a2a13d ([JDK-8326718](https://bugs.openjdk.org/browse/JDK-8326718)) added a few cases to test java/util/Formatter/Padding.java with huge Strings as arguments. Since all possible argument combinations for the test are stored in one array, nothing can be garbage collected while the test is running and the heap requirement is blown up.
>> 
>> In one of our test pipelines we run tier1 tests with VMs that default to 384M of heap and this is not sufficient any longer.
>> 
>> I'm improving this by splitting the one large @ParameterizedTest into multiple ones. With that, I could run the test successfully in a test VM with 96M of heap, e.g. by modifying `@run junit Padding` to `@run junit/othervm -Xmx96m Padding`
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review suggestions

Marked as reviewed by rgiulietti (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18264#pullrequestreview-1936282689


More information about the core-libs-dev mailing list