RFR: 8325621: Improve jspawnhelper version checks [v4]
Erik Joelsson
erikj at openjdk.org
Thu Mar 14 13:25:45 UTC 2024
On Wed, 13 Mar 2024 17:11:25 GMT, Chad Rakoczy <duke at openjdk.org> wrote:
>> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>>
>> Updates jspawnhelper to check that JDK version and jspawnhelper version are the same. Updates test to include check for version. Also tested manually by replacing jspawnhelper with incorrect version to confirm that check works.
>
> Chad Rakoczy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>
> - Merge branch 'master' into JDK-8325621-2
> - Update style and improve error messages
> - Print to stdout instead of stderr
> - Compare version using VERSION_STRING
> - Code cleanup
> - Remove string.h include
> - Update test
> - Pass version as integer instead of string
> - Read in version using int instead of string
> - 8325621: Improve jspawnhelper version checks
Marked as reviewed by erikj (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/18204#pullrequestreview-1936699901
More information about the core-libs-dev
mailing list