RFR: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap [v2]

Mark Sheppard msheppar at openjdk.org
Thu Mar 14 13:59:40 UTC 2024


On Thu, 14 Mar 2024 12:15:39 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this test-only change which proposes to address https://bugs.openjdk.org/browse/JDK-8328066?
>> 
>> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue, the failure was observed on linux-86 instance on a GitHub jobs run. 
>> 
>> The commit in this PR proposes to add relevant `@requires` so that the test is only run on 64 bit VM and expects the `os.maxMemory` to be > 2G.
>> 
>> The change has been tested on a linux-x86 run in GitHub actions job, plus even on local and CI 64 bit VM environments. No failures have been noticed.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   combine requires into one line

I think the os.maxMemory is an artificial constraint.
a requirement to run on 64 bit machine should be sufficient
@requires vm.bits == "64"

as the issue relates to the max user virtual address space available on 32 bit architecture

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18290#issuecomment-1997521612


More information about the core-libs-dev mailing list