RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v20]

[Erik Joelsson]

On Thu, 14 Mar 2024 20:54:32 GMT, Mandy Chung <mchung at openjdk.org> wrote:

> About the configure options,
> 
> ```
>   --enable-keep-packaged-modules
>                           enable keeping of packaged modules in jdk image [enabled]
>   --enable-runtime-link-image
>                           enable producing an image suitable for runtime linking [disabled]
> ```
> 
> If `--enable-runtime-link-image` is enabled, the JDK image does not include the packaged modules. If `--enable-runtime-link-image --enable-keep-packaged-modules` are both enabled, it should probably fail? @erikj79 should it?

That's a good question. I was pondering the logic myself during my last review, but didn't come to any good conclusion so didn't comment on it. The problem I think is that `--enable-keep-packaged-modules` is default enabled. I think when that option isn't explicitly set, the default needs to depend on the value of `--enable-runtime-link-image`. Setting both to enabled explicitly doesn't seem to make any sense, so that case should probably result in failure as you say.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-1998496745