RFR: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket [v5]
Christoph Langer
clanger at openjdk.org
Fri Mar 15 06:40:40 UTC 2024
On Thu, 7 Mar 2024 17:37:59 GMT, Christoph Langer <clanger at openjdk.org> wrote:
> > > Thanks for exploring the possibility of improving tracebility of test invocations to reported bugs.
> > > >
> >
> >
> > I've given this test change a second thought, maybe you can try to separate the test into two separate test classes? One possibility to avoid duplicating code and have a separate test for each bug is to introduce a base test class that will contain the common functionality for [JDK-8314063](https://bugs.openjdk.org/browse/JDK-8314063) and [JDK-8325579](https://bugs.openjdk.org/browse/JDK-8325579) tests.
>
> I will have a look.
I stared at the test once more but it still doesn't make sense to me to split it into multiple tests because the purposes of each test run intertwine, as stated [above](https://github.com/openjdk/jdk/pull/17797#issuecomment-1959271452). The only thing that would really make sense is to rename from LdapSSLHandshakeFailureTest to LdapSSLHandshakeTest since it in fact tests various variations of the SSL handshaking.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17797#issuecomment-1999031201
More information about the core-libs-dev
mailing list