RFR: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap [v3]

[Jaikiran Pai]

On Thu, 14 Mar 2024 14:04:51 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this test-only change which proposes to address https://bugs.openjdk.org/browse/JDK-8328066?
>> 
>> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue, the failure was observed on linux-86 instance on a GitHub jobs run. 
>> 
>> The commit in this PR proposes to add relevant `@requires` so that the test is only run on 64 bit VM and expects the `os.maxMemory` to be > 2G.
>> 
>> The change has been tested on a linux-x86 run in GitHub actions job, plus even on local and CI 64 bit VM environments. No failures have been noticed.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Mark's suggestion - no need for os.maxMemory

Hello Mark,

> maybe ask the question: why does the test need 2GB ? Would 1Gb suffice and that would be within the allocation limits for 32 bit architectures virtual address space.

The reason why 2GB is needed in this test is explained in https://bugs.openjdk.org/browse/JDK-8285386.

I see that Andrew (and previously Daniel) have approved this change and the updated version checks only for `vm.bits == 64` as suggested by you. If you think the current form of the PR looks good, then I'll go ahead and integrate this - since I don't plan to investigate an ideal heap size for running this on 32 bit VMs.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18290#issuecomment-1999463552