RFR: 8327994: Update code gen in CallGeneratorHelper [v2]

Andrey Turbanov aturbanov at openjdk.org
Sat Mar 16 22:34:26 UTC 2024


On Sat, 16 Mar 2024 15:41:06 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Update the code gen code in CallGeneratorHelper to reflect the latest state of the libTest(Downcall/Upcall)(Stack).c and shared.h files.
>> 
>> - The previous code wanted users to pipe stdout into a file. But, since we have 5 files that need to be created, and the names of those files is important too, I've changed the script to write to those files directly instead.
>> - I moved the definition of `S_FFFF` to libVarArgs.c where it's used, as it's not actually generated by CallGeneratorHelper.
>> - GitHub doesn't render the changes to some of the files, but those files only contain either white space changes (some missing spaces after `,`), and copyright header updates.
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Delete extra space
>   
>   Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>

test/jdk/java/foreign/CallGeneratorHelper.java line 195:

> 193:     }
> 194: 
> 195:     private  static void generateStructDecl(PrintStream out, List<StructFieldType> fields) {

Suggestion:

    private static void generateStructDecl(PrintStream out, List<StructFieldType> fields) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18269#discussion_r1527165383


More information about the core-libs-dev mailing list