RFR: JDK-8326853 Missing @since tags for Charset related methods added in Java 10 [v7]

Justin Lu jlu at openjdk.org
Tue Mar 19 16:16:24 UTC 2024


On Tue, 19 Mar 2024 10:54:41 GMT, Nizar Benalla <duke at openjdk.org> wrote:

>> # Issue
>> - JDK-8326853 Incorrect @\since Tags for Charset Related Methods Added in JDK 10
>> 
>> I changed the @\since tags to better accurately show when the methods and constructors were introduced.
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update the latter years for the Oracle copyrights

src/java.base/share/classes/java/nio/channels/Channels.java line 2:

> 1: /*
> 2:  * Copyright (c) 2000, 2023, 2024, Oracle and/or its affiliates. All rights reserved.

Thanks for updating, but needs a little adjustment.

Rather than adding a third year, the format should be: "original year, current year, Oracle ..."
So in this case ->  `2000, 2024,`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18032#discussion_r1530694415


More information about the core-libs-dev mailing list