RFR: 8327791: Optimization for new BigDecimal(String) [v14]
Claes Redestad
redestad at openjdk.org
Wed Mar 20 21:01:24 UTC 2024
On Thu, 14 Mar 2024 00:00:53 GMT, Shaojin Wen <duke at openjdk.org> wrote:
>> The current BigDecimal(String) constructor calls String#toCharArray, which has a memory allocation.
>>
>>
>> public BigDecimal(String val) {
>> this(val.toCharArray(), 0, val.length()); // allocate char[]
>> }
>>
>>
>> When the length is greater than 18, create a char[]
>>
>>
>> boolean isCompact = (len <= MAX_COMPACT_DIGITS); // 18
>> if (!isCompact) {
>> // ...
>> } else {
>> char[] coeff = new char[len]; // allocate char[]
>> // ...
>> }
>>
>>
>> This PR eliminates the two memory allocations mentioned above, resulting in an approximate 60% increase in performance..
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>
> bug fix for CharArraySequence#charAt
src/java.base/share/classes/java/math/BigDecimal.java line 576:
> 574: long rs = 0; // the compact value in long
> 575: BigInteger rb = null; // the inflated value in BigInteger
> 576: // use String bounds checking to handle too-long, len == 0,
Suggestion:
// use CharSequence bounds checking to handle too-long, len == 0,
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18177#discussion_r1532860171
More information about the core-libs-dev
mailing list