RFR: 8328316: Finisher cannot emit if stream is sequential and integrator returned false [v4]
Paul Sandoz
psandoz at openjdk.org
Thu Mar 21 16:52:24 UTC 2024
On Wed, 20 Mar 2024 23:58:32 GMT, Viktor Klang <vklang at openjdk.org> wrote:
>> Adds differentiation between direct and transitive short circuiting which could prevent pushing downstream in the finisher for built-ins that were not `collect()`.
>>
>> Creating this as a draft PR for now, just need to run some benchmarks to validate no significant regressions first.
>
> Viktor Klang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Updating copyright year and switching to use underscores in GathererShortCircuitTest
> - Adds differentiation between direct and transitive short circutiting for Gatherers
Marked as reviewed by psandoz (Reviewer).
src/java.base/share/classes/java/util/stream/GathererOp.java line 2:
> 1: /*
> 2: * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
Suggestion:
* Copyright (c) 2023, 2024, Oracle and/or its affiliates. All rights reserved.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18351#pullrequestreview-1952810339
PR Review Comment: https://git.openjdk.org/jdk/pull/18351#discussion_r1534280411
More information about the core-libs-dev
mailing list