RFR: 8320396: Class-File API ClassModel::verify should include checks from hotspot/share/classfile/classFileParser.cpp [v2]

Adam Sotona asotona at openjdk.org
Fri Mar 22 09:10:25 UTC 2024


On Fri, 22 Mar 2024 02:17:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 26 commits:
>> 
>>  - Merge remote-tracking branch 'openjdk/master' into JDK-8320396-verifier-extension
>>  - work in progress
>>  - work in progress
>>  - work in progress
>>  - work in progress
>>  - work in progress
>>  - removed string templates from test
>>  - work in progress
>>  - work in progress
>>  - work in progress
>>  - ... and 16 more: https://git.openjdk.org/jdk/compare/e41bc42d...54c4e9b9
>
> src/java.base/share/classes/jdk/internal/classfile/impl/verifier/ParserVerifier.java line 56:
> 
>> 54: 
>> 55: /**
>> 56:  * @see <a href="https://raw.githubusercontent.com/openjdk/jdk/master/src/hotspot/share/classfile/classFileParser.cpp">hotspot/share/classfile/classFileParser.cpp</a>
> 
> A reference to JVMS Ch4(?) would be appropriate here as that is what any checks should be compliant with.

Thank you for the review, I've added references to JVMS.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16809#discussion_r1535265201


More information about the core-libs-dev mailing list