RFR: 8328995: launcher can't open jar files where the offset of the manifest is >4GB [v4]

Liam Miller-Cushon cushon at openjdk.org
Fri Mar 29 17:38:47 UTC 2024


On Fri, 29 Mar 2024 17:32:11 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> Thanks for the catch, I had missed that the disk start number is 4 bytes and not 8. I pushed a commit. I also removed some unused references to the disk number, which is only being used to validate the size of the zip64 extended info.
>
> Ok. Could you please also fix the above `36`? Please change the start of `//` (comment) to be aligned with the earlier comment lines.

Done, thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18479#discussion_r1544722502


More information about the core-libs-dev mailing list