RFR: 8328995: launcher can't open jar files where the offset of the manifest is >4GB [v3]
Jiangli Zhou
jiangli at openjdk.org
Fri Mar 29 18:05:33 UTC 2024
On Fri, 29 Mar 2024 17:50:00 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:
>> src/java.base/share/native/libjli/parse_manifest.c line 505:
>>
>>> 503: Byte *base = p + CENHDR + CENNAM(p);
>>> 504: jlong offset = 0;
>>> 505: while (offset < cenext) {
>>
>> Any reason why a loop is need here?
>
> There can be multiple extra fields, and the zip64 extended information may not be the first one
Could you please point to the related spec for the other `extra field`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18479#discussion_r1544739399
More information about the core-libs-dev
mailing list