RFR: 8331724: Refactor j.l.constant implementation to internal package [v2]

Chen Liang liach at openjdk.org
Mon May 6 15:12:21 UTC 2024


On Mon, 6 May 2024 15:03:53 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/constant/ReferenceClassDescImpl.java line 68:
>> 
>>> 66:      * @jvms 4.3.2 Field Descriptors
>>> 67:      */
>>> 68:     public static ReferenceClassDescImpl ofTrusted(String descriptor) {
>> 
>> If you named `ofTrusted` to be in parity with the MTDImpl factory, they are different as MTD one means array is trusted; this one means descriptor is already valid.
>
> `ofValidated`?

Sounds good to me, as long as the 2 factories take any different name combination so we don't think they both bypass everything

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19105#discussion_r1591152653


More information about the core-libs-dev mailing list