RFR: 8331744: java.lang.classfile.TypeKind improvements [v2]
Chen Liang
liach at openjdk.org
Tue May 7 01:14:31 UTC 2024
> A peek into TypeKind during the research for #19105 reveals that TypeKind has a few issues:
> 1. Name mismatch for `newarraycode` and `fromNewArrayCode`: Renamed both to use "newarray code"
> 2. `fromDescriptor` can throw IOOBE if the input string is empty: changed to throw IAE and added tests.
> 3. `from(Class)` can be slow due to descriptor computation: added benchmark, will share result in next comment (as it may change with code changes).
>
> The first 2 changes involves API changes, and a CSR has been created. Requesting @asotona for a review.
Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
Update test/micro/org/openjdk/bench/java/lang/classfile/TypeKindBench.java
Co-authored-by: Claes Redestad <claes.redestad at oracle.com>
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/19109/files
- new: https://git.openjdk.org/jdk/pull/19109/files/82e46cdf..9338f901
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=19109&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=19109&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/19109.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19109/head:pull/19109
PR: https://git.openjdk.org/jdk/pull/19109
More information about the core-libs-dev
mailing list