RFR: 8331744: java.lang.classfile.TypeKind improvements [v4]
Chen Liang
liach at openjdk.org
Tue May 7 15:23:10 UTC 2024
> A peek into TypeKind during the research for #19105 reveals that TypeKind has a few issues:
> 1. Name mismatch for `newarraycode` and `fromNewArrayCode`: Renamed both to use "newarray code"
> 2. `fromDescriptor` can throw IOOBE if the input string is empty: changed to throw IAE and added tests.
> 3. `from(Class)` can be slow due to descriptor computation: added benchmark, will share result in next comment (as it may change with code changes).
>
> The first 2 changes involves API changes, and a CSR has been created. Requesting @asotona for a review.
Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
Hash table, use fixed random seed
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/19109/files
- new: https://git.openjdk.org/jdk/pull/19109/files/adf1218c..9af30c65
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=19109&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=19109&range=02-03
Stats: 68 lines in 3 files changed: 53 ins; 8 del; 7 mod
Patch: https://git.openjdk.org/jdk/pull/19109.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19109/head:pull/19109
PR: https://git.openjdk.org/jdk/pull/19109
More information about the core-libs-dev
mailing list