RFR: 8331724: Refactor j.l.constant implementation to internal package [v4]

Chen Liang liach at openjdk.org
Tue May 7 17:04:52 UTC 2024


On Tue, 7 May 2024 16:40:08 GMT, ExE Boss <duke at openjdk.org> wrote:

>> `currentDepth` must be 0 in this case, so `rank` or `netRank` doesn't matter. Overriding in `PrimitiveClassDescImpl` sounds reasonable, but then perhaps default method should be removed, too, since it would look strange to have the default method be specialized for instance/array types. Sounds like a CSR might be needed(?), so let's do that in a follow up.
>
> I don’t think a **CSR** is needed for changing the `default`ness of JDK‑sealed interface methods, as source and binary compatibility for external users is unaffected.

A CSR is required when defaultness is removed, as in https://bugs.openjdk.org/browse/JDK-8309755

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19105#discussion_r1592810075


More information about the core-libs-dev mailing list