RFR: 8330005: RandomGeneratorFactory.getDefault() throws exception when the runtime image only has java.base module [v6]
Jaikiran Pai
jpai at openjdk.org
Wed May 8 05:31:55 UTC 2024
On Sat, 4 May 2024 18:29:25 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:
>> Move all random generators mandated in package `java.util.random` and currently implemented in module `jdk.random` to module `java.base`, and remove module `jdk.random`.
>
> Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>
> - Merge branch 'master' into 8330005
> - Restrict RandomGenerator service providers to those loadable by the platform class loader.
> - Typo.
> - Added @uses javadoc tag for j.u.r.RandomGenerator in java.base.
> - Terminology changes.
> - Renamed package jdk.random to jdk.internal.random.
> - 8330005: RandomGeneratorFactory.getDefault() throws exception when the runtime image only has java.base module
Hello Raffaello, the proposed changes look OK to me. Do you think we should add a jtreg test for this?
In general, the test coverage for these APIs appears to be missing. I think that can be addressed separately in some of the upcoming changes.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18932#pullrequestreview-2044656083
More information about the core-libs-dev
mailing list