RFR: 8305457: Implement java.io.IO [v3]
Jaikiran Pai
jpai at openjdk.org
Wed May 8 05:44:54 UTC 2024
On Tue, 7 May 2024 19:46:18 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and three methods to `java.io.Console` for [Implicitly Declared Classes and Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git merge --squash` of a now obsolete [draft PR].
>>
>> [Implicitly Declared Classes and Instance Main Methods (Third Preview)]: https://bugs.openjdk.org/browse/JDK-8323335
>> [draft PR]: https://github.com/openjdk/jdk/pull/18921
>
> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>
> Strengthen tests after 8330998
>
> https://github.com/openjdk/jdk/pull/18996 now allows us to test
> Console IO better.
src/java.base/share/classes/java/io/Console.java line 188:
> 186:
> 187: /**
> 188: * Writes a prompt as if by calling {@code print}, then reads a single line
Should `{@code print}` instead be `{@link Console#print() print()}`?
src/java.base/share/classes/java/io/Console.java line 192:
> 190: *
> 191: * @param prompt
> 192: * A prompt string.
Hello Pavel, should this specify whether `prompt` can be null?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1593411945
PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1593411393
More information about the core-libs-dev
mailing list