RFR: 8305457: Implement java.io.IO [v3]
Jaikiran Pai
jpai at openjdk.org
Wed May 8 05:51:00 UTC 2024
On Wed, 8 May 2024 05:45:55 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Strengthen tests after 8330998
>>
>> https://github.com/openjdk/jdk/pull/18996 now allows us to test
>> Console IO better.
>
> src/java.base/share/classes/java/io/Console.java line 194:
>
>> 192: * A prompt string.
>> 193: *
>> 194: * @throws IOError
>
> I'm guessing this specifies `IOError` instead of `IOException` so that the caller doesn't have to handle a checked exception? If so, would it be better to throw an `java.io.UncheckedIOException`, to avoid throwing `Error`s?
Actually, it appears that the existing APIs on `java.io.Console` are specified to throw a `java.io.IOError`. So this isn't something new that is being introduced. So please ignore that question.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1593416464
More information about the core-libs-dev
mailing list