RFR: 8326227: Rounding error that may distort computeNextGaussian results [v3]
Chris Hennick
duke at openjdk.org
Thu May 9 03:58:56 UTC 2024
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick <duke at openjdk.org> wrote:
>> This provides a slightly more accurate bounding limit for `computeNextExponentialSoftCapped` when calling it from `computeNextGaussian`. This could cause the `while (computeNextExponentialSoftCapped(rng, limit) < limit)` check in `computeNextGaussian` on line 1402 to always be true, making the `nextGaussian` runtime unbounded in the worst case; but more likely, it would give a result that was truncated too close to zero.
>>
>> This change is being tested prior to submission to OpenJDK by https://github.com/openjdk/jdk/pull/17703/commits/b8be051cbf40a6a05fafc6a2c76942e9e0b11fdf.
>
> Chris Hennick has updated the pull request incrementally with one additional commit since the last revision:
>
> Bug fix: add-exports was for wrong package
Keep open. @JimLaskey it looks like you're the author of most of the surrounding code; can you please confirm that there's a rounding error in the existing implementation and that this PR will fix it?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17703#issuecomment-2101885931
More information about the core-libs-dev
mailing list