RFR: 8331876: JFR: Move file read and write events to java.base [v3]

[Erik Gahlin]

On Thu, 9 May 2024 07:33:22 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java line 78:
>> 
>>> 76: 
>>> 77:     // Flag that determines if file reads/writes should be traced by JFR
>>> 78:     private static boolean jfrTracing;
>> 
>> Should the force method be changed to test this flag too?
>> 
>> I'm also wondering about the transferXXX methods. We might want to think about these for a separate PR as they have more potential to be outliers than the read/write methods.
>
> I think it would be good to use the flag for all events, but I rather do it as separate PR so this is mostly a mechanical change to remove ASM. It makes it easier to track regressions or improvements.
> 
> I can file an enhancement for the transferXXX methods.

"JFR: Add file event support for transfer methods"
https://bugs.openjdk.org/browse/JDK-8331995

"JFR: Add boolean check before loading event classes"
https://bugs.openjdk.org/browse/JDK-8331996

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19129#discussion_r1595353143