RFR: 8305457: Implement java.io.IO [v5]

[Jonathan Gibbons]

On Thu, 9 May 2024 14:23:37 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Please review this PR which introduces the `java.io.IO` top-level class and three methods to `java.io.Console` for [Implicitly Declared Classes and Instance Main Methods (Third Preview)].
>> 
>> This PR has been obtained as `git merge --squash` of a now obsolete [draft PR].
>> 
>> [Implicitly Declared Classes and Instance Main Methods (Third Preview)]: https://bugs.openjdk.org/browse/JDK-8323335
>> [draft PR]: https://github.com/openjdk/jdk/pull/18921
>
> Pavel Rappo has updated the pull request incrementally with five additional commits since the last revision:
> 
>  - Simplify output.exp
>  - Cover null prompt in input tests
>  - Make input test parametric
>  - Specify behaviour in regard to null
>  - Add explicit @throws IOError to IO methods

(Minor). at least within the context of this PR, tags like `@param` and `@throws` are stylistically inconsistent as to whether they begin with a capital letter and end with a period.  (I have not checked for local consistency within the affected files.)

test/jdk/java/io/IO/IO.java line 125:

> 123:      * To simulate a terminal, the test currently uses the EXPECT(1) Unix
> 124:      * command, which does not work for Windows. Later, a library like pty4j
> 125:      * or JPty might be used instead EXPECT, to cover both Unix and Windows.

Possible missing word `of`: `instead of EXPECT`

-------------

PR Review: https://git.openjdk.org/jdk/pull/19112#pullrequestreview-2048123137
PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1595543569