RFR: 8331744: java.lang.classfile.TypeKind improvements [v5]

Chen Liang liach at openjdk.org
Thu May 9 21:15:31 UTC 2024


> A peek into TypeKind during the research for #19105 reveals that TypeKind has a few issues:
> 1. Name mismatch for `newarraycode` and `fromNewArrayCode`: Renamed both to use "newarray code"
> 2. `fromDescriptor` can throw IOOBE if the input string is empty: changed to throw IAE and added tests.
> 3. `from(Class)` can be slow due to descriptor computation: added benchmark, will share result in next comment (as it may change with code changes).
> 
> The first 2 changes involves API changes, and a CSR has been created. Requesting @asotona for a review.

Chen Liang has updated the pull request incrementally with two additional commits since the last revision:

 - Restore fixed seed
 - Revert "Hash table, use fixed random seed"
   
   This reverts commit 9af30c65d2c7be3535e4483e278151bc4473d63c.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19109/files
  - new: https://git.openjdk.org/jdk/pull/19109/files/9af30c65..ae9e793e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19109&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19109&range=03-04

  Stats: 64 lines in 2 files changed: 8 ins; 51 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/19109.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19109/head:pull/19109

PR: https://git.openjdk.org/jdk/pull/19109


More information about the core-libs-dev mailing list