RFR: 8331535: Incorrect prompt for Console.readLine [v6]

Adam Sotona asotona at openjdk.org
Fri May 10 15:34:27 UTC 2024


On Fri, 10 May 2024 15:32:07 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> When JLine reads a line, there may be a prompt provided. However, JLine will not interpret the prompt literally, it will handle `%` specially. As a consequence, doing:
>> 
>> System.console().readLine("%%s");
>> 
>> 
>> will not print `%s`, as first `String.format` is used, which will convert `%%s` to `%s`, and then JLine will interpret the `%`. The proposed solution is to duplicate the `%`, so that JLine will print it.
>
> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test/jdk/java/io/Console/ConsolePromptTest.java
>   
>   Co-authored-by: Adam Sotona <10807609+asotona at users.noreply.github.com>

Looks good to me.

-------------

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19081#pullrequestreview-2050327444


More information about the core-libs-dev mailing list