RFR: 8331907: BigInteger and BigDecimal should use optimized division [v4]
Raffaello Giulietti
rgiulietti at openjdk.org
Fri May 10 16:47:04 UTC 2024
On Fri, 10 May 2024 16:16:18 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> Replace the custom unsigned divide / remainder functions with the compiler-optimized Long.divideUnsigned / remainderUnsigned.
>>
>> No new tests. Existing tier1-3 tests continue to pass.
>>
>> I added a new set of divide benchmarks. Results in thread.
>>
>> I also removed the BigDecimal.toString benchmarks. They no longer serve their purpose - toString caches the returned value, so we were only benchmarking the cache access time.
>
> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
>
> Integer divide
LGTM
-------------
Marked as reviewed by rgiulietti (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19134#pullrequestreview-2050461848
More information about the core-libs-dev
mailing list