RFR: 8327499: MethodHandleStatics.traceLambdaForm includes methods that cannot be generated [v2]

Ioi Lam iklam at openjdk.org
Fri May 10 20:05:16 UTC 2024


On Fri, 10 May 2024 04:55:21 GMT, Chen Liang <liach at openjdk.org> wrote:

>> GenerateJLIClassesHelper has been making wrong assumptions about Invoker's LambdaForm method type parameters. Since they are distinct from those of Linkers, they are now tracked and generated separately. It seems that no proper invoker was ever generated before, except it happens that most invoker signatures can be taken as linker signature so we never detected it.
>> 
>> Requesting @iklam for a review; since I don't know how to deal with CDS, I have to relay to someone else to ensure this fixes the problem from the CDS side as well.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add CDS test case to ensure LF resolution success

Looks good to me. Thanks for adding the CDS test.

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19164#pullrequestreview-2050787955


More information about the core-libs-dev mailing list