RFR: 8331876: JFR: Move file read and write events to java.base [v3]

Alan Bateman alanb at openjdk.org
Sat May 11 15:05:13 UTC 2024


On Thu, 9 May 2024 11:19:14 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Hi,
>> 
>> Could I have a review of a change that moves the jdk.FileRead and jdk.FileWrite events to java.base to remove the use of the ASM instrumentation.
>> 
>> Testing: jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move methods

src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java line 419:

> 417: 
> 418:     private long implWrite(ByteBuffer[] srcs, int offset, int length) throws IOException
> 419:     {

Style nit here, the "{" can move to the end of L418.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19129#discussion_r1597461653


More information about the core-libs-dev mailing list