RFR: 8322332: Add API to access ZipEntry.extraAttributes

- liangchenblue at gmail.com
Sun May 12 20:56:03 UTC 2024


Hi Alan Snyder,
Currently, JDK ZipEntry populates that extraAttributes (proposed to rename
to externalFileAttributes in JDK-8321274, PR #16952) only if the high byte
of the "version made by" field is 3 (indicating Linux compatibility) and
only records the most significant 2 bytes for the copied ZipEntry.
Since this is not the "external file attributes" field from the ZIP format,
do you still think this field should be exposed, or should we create a new
field to properly model the external file attributes? Also worth noting is
the support for adjusting the "version made by" field, the "external file
attributes" field might be misinterpreted without it.

P.S. Seems the Skara bridge is not propagating emails to GitHub comments.

On Sun, May 12, 2024 at 2:17 PM Alan Snyder <javalists at cbfiddle.com> wrote:

> > It might be interesting to explore that in the context of the zip file
> system provider, less sure about the java.util.zip APIs.
>
> I was not using the Zip file system. I was processing a Zip file.
>
>   Alan
>
>
>
>
>
> > On May 12, 2024, at 7:32 AM, Chen Liang <liach at openjdk.org> wrote:
> >
> > On Sun, 12 May 2024 02:48:31 GMT, xiaotaonan <duke at openjdk.org> wrote:
> >
> >> Add API to access ZipEntry.extraAttributes
> >
> > Also see #16952, another patch that renames this field, which is
> planning for an integration soon; this PR will be out-of-date when that one
> is integrated.
> >
> > -------------
> >
> > PR Comment:
> https://git.openjdk.org/jdk/pull/19204#issuecomment-2106265843
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/core-libs-dev/attachments/20240512/7384290b/attachment.htm>


More information about the core-libs-dev mailing list