RFR: 8332084: Ensure JdkConsoleImpl.restoreEcho visibility in a shutdown hook [v4]

Stuart Marks smarks at openjdk.org
Tue May 14 18:57:14 UTC 2024


On Mon, 13 May 2024 21:32:18 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Making sure `restoreEcho` correctly reflects the state in the shutdown thread, which differs from the application's thread that issues the `readPassword()` method.
>
> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addresses a review comment

Ah, ok, so each provider has its own shutdown hook, so it's never the case that both hooks are installed at the same time and can conflict with each other. The `java.base` console provider tracking and restoring echo status on its own is probably fine.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19184#issuecomment-2110926249


More information about the core-libs-dev mailing list