RFR: 8332086: Remove the usage of ServiceLoader in j.u.r.RandomGeneratorFactory [v4]

[Jaikiran Pai]

On Tue, 14 May 2024 16:08:22 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> All random number generator algorithms are implemented in module `java.base`. The usage of `ServiceLoader` in `j.u.r.RandomGeneratorFactory` is no longer needed.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replace SimpleImmutableEntry constructor with Map.entry() factory method.

Thank you for these updates Raffaello. I think the implementation is looking much more simpler and cleaner now. I've a few documentation related review comments which I've added inline. I haven't reviewed the test change yet.

src/java.base/share/classes/java/util/random/package-info.java line 85:

> 83:  * Then one can choose a specific implementation by giving the name of a generator
> 84:  * algorithm to the static method {@link RandomGenerator#of}, in which case no
> 85:  * seed is specified by the caller:

Perhaps reword this to:


> ... in which case a {@code RandomGenerator} is constructed without any seed value:

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19212#issuecomment-2111679665
PR Review Comment: https://git.openjdk.org/jdk/pull/19212#discussion_r1601015731