RFR: 8321622: ClassFile.verify(byte[] bytes) throws unexpected ConstantPoolException, IAE

[Jaikiran Pai]

On Thu, 16 May 2024 06:44:29 GMT, Adam Sotona <asotona at openjdk.org> wrote:

> Class-File API `VerifierImpl` contains debugging stack trace print causing unexpected output and confusion in specific verification cases.
> 
> This patch removes the stack trace print.
> 
> Please review.
> 
> Thanks,
> Adam

Hello Adam, the change looks OK to me. The file needs a copyright year update before integrating.

On an unrelated note, the class level javadoc has some `@see` usages which use URLs pointing to `https://raw.githubusercontent.com/openjdk/jdk...`. Are those intentional? Of course, this is an internal class so the javadoc won't be published.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19258#pullrequestreview-2059775369