RFR: 8331876: JFR: Move file read and write events to java.base [v5]

Alan Bateman alanb at openjdk.org
Fri May 17 09:24:03 UTC 2024


On Thu, 16 May 2024 12:10:46 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Hi,
>> 
>> Could I have a review of a change that moves the jdk.FileRead and jdk.FileWrite events to java.base to remove the use of the ASM instrumentation.
>> 
>> Testing: jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove dependency on JFR for retransformation

src/java.base/share/classes/java/io/FileInputStream.java line 65:

> 63:     /**
> 64:      * Flag set by jdk.internal.event.JFRTracing to determines if
> 65:      * file reads should be traced by JFR.

s/determines if/indicate if/

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19129#discussion_r1604617070


More information about the core-libs-dev mailing list