RFR: 8332597: Remove redundant methods from j.l.classfile.ClassReader API

[Chen Liang]

On Tue, 21 May 2024 09:20:36 GMT, Adam Sotona <asotona at openjdk.org> wrote:

> j.l.classfile.ClassReader instance is exposed in the Class-File API through j.l.classfile.AttributeMapper::readAttribute method only.
> ClassReader only purpose is to serve as a tool for reading content of a custom attribute in a user-provided AttribtueMapper.
> It contains useful set of low-level class reading methods for user to implement a custom attribute content parser.
> 
> However methods ClassReader::thisClassPos and ClassReader::skipAttributeHolder are not necessary for a custom attribute content parsing and so redundant in the API.
> Class-File API implementation internally use these methods, however they should not be exposed in the API.
> 
> This patch removes the methods from the API.
> 
> Please review.
> 
> Thanks,
> Adam

Marked as reviewed by liach (Author).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19323#pullrequestreview-2068383252