RFR: 8305457: Implement java.io.IO [v10]

[Pavel Rappo]

On Tue, 21 May 2024 19:55:22 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits:
>> 
>>  - Add diagnostic output
>>  - Use "expect" that was found
>>  - Merge branch 'master' into 8305457-Implement-java.io.IO
>>    
>>    # Conflicts:
>>    #	src/java.base/share/classes/java/io/ProxyingConsole.java
>>    #	src/java.base/share/classes/jdk/internal/io/JdkConsole.java
>>    #	src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java
>>    #	src/jdk.internal.le/share/classes/jdk/internal/org/jline/JdkConsoleProviderImpl.java
>>    #	src/jdk.jshell/share/classes/jdk/jshell/execution/impl/ConsoleImpl.java
>>  - Escape prompt
>>  - Merge branch 'master' into 8305457-Implement-java.io.IO
>>  - Clarify input charset
>>  - Make IO final
>>  - Fix System.console().readln(null) in jshell
>>    
>>    Without it, jshell hangs on me. Will think of a test.
>>  - Fix typo
>>  - Merge branch 'master' into 8305457-Implement-java.io.IO
>>  - ... and 10 more: https://git.openjdk.org/jdk/compare/b92bd671...809e98e0
>
> src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line 78:
> 
>> 76:         String line = null;
>> 77:         synchronized (writeLock) {
>> 78:             synchronized(readLock) {
> 
> Suggestion:
> 
>             synchronized (readLock) {

Sorry, but no. It would be inconsistent with the rest of the file, which for whatever reason (copy-paste?) does not use whitespace between `synchronized` and `(readLock)`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1608962852