RFR: 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM

Jaikiran Pai jpai at openjdk.org
Wed May 22 05:21:18 UTC 2024


Can I please get a review of this test-only change for addressing https://bugs.openjdk.org/browse/JDK-8332490?

The jmh test opens a `InflaterInputStream`, reads the stream contents, but then doesn't close the stream. This can lead to resource leak which can then cause OOM as noted in that JBS issue.

The commit in this PR closes the `InflaterInputStream` when the reads complete.


make test TEST=micro:org.openjdk.bench.java.util.zip.InflaterInputStreams

and


./build/macosx-aarch64/images/jdk/bin/java -jar ./build/macosx-aarch64/images/test/micro/benchmarks.jar org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead -t max -f 1 -wi 2 -foe true

pass after this change.

-------------

Commit messages:
 - 8332490: JMH org.openjdk.bench.java.util.zip.InflaterInputStreams.inflaterInputStreamRead OOM

Changes: https://git.openjdk.org/jdk/pull/19340/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19340&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8332490
  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/19340.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19340/head:pull/19340

PR: https://git.openjdk.org/jdk/pull/19340


More information about the core-libs-dev mailing list