RFR: 8327964: Simplify BigInteger.implMultiplyToLen intrinsic [v5]

Yudi Zheng yzheng at openjdk.org
Wed May 22 14:47:43 UTC 2024


On Wed, 17 Apr 2024 20:04:44 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Yudi Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address comment.
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 6662:
> 
>> 6660:   push(tmp5);
>> 6661: 
>> 6662:   push(xlen);
> 
> There may be an opportunity here (separate RFE?) to get rid of the save/restore for these.  I don't think it's necessary if this is called as part of a C2 stub.

In the Graal port we did get rid of these save/restore.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18226#discussion_r1610126799


More information about the core-libs-dev mailing list