RFR: 8332528: Generate code in SwitchBootstraps.generateTypeSwitch that require fewer adaptations [v3]
Claes Redestad
redestad at openjdk.org
Thu May 23 11:09:15 UTC 2024
On Thu, 23 May 2024 09:46:51 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
>> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add type switch to HelloClasslist
>
> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 53:
>
>> 51: import java.lang.classfile.instruction.SwitchCase;
>> 52:
>> 53: import jdk.internal.constant.MethodTypeDescImpl;
>
> Nit - this import seems to be unused, and neither seem to be the changes to `MethodTypeDescImpl`. Is there some use missing? (OTOH, I like the `StaticHolders` for the stuff that relates to the enum-switch special case, for the time being.)
Oops, some leftovers from the optimizations I reverted. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19307#discussion_r1611478359
More information about the core-libs-dev
mailing list